connections

This is a Bazaar branch. To clone, pull or merge from it, use this URL.

For more help, check out the 5-minute Quick Hacking with Bzr or the full Introduction to Bzr.

Log

1607 : 2008-06-29 : Jelmer Vernooij : jelmer@samba.org-20080629150511-p63o8vrehn1erp0r

Properly track nick names when falling back to another name because the initial one was in use.

1606 : 2008-06-29 : Jelmer Vernooij : jelmer@samba.org-20080629145705-8kvz0pbx4mg67t3i

Add support for UHNAMES and ESILENCE.

1605 : 2008-06-29 : Jelmer Vernooij : jelmer@samba.org-20080629145025-72212tydz106o2mi

Avoid unknown command warning when using PASS.

1604 : 2008-06-29 : Jelmer Vernooij : jelmer@samba.org-20080629141854-1j0k146xs9ud3tms

Warn on rather than ignore invalidly formatted lines in nickserv file.

1603 : 2008-06-29 : Jelmer Vernooij : jelmer@samba.org-20080629141157-2jqfciayq2i0mdsq

Don't write to nickserv file either if autosave=false.

1602 : 2008-06-29 : Jelmer Vernooij : jelmer@samba.org-20080629141037-j81l3vso7nsungcq

remove reference to ppp secrets files, as the order in the nickserv file is slightly different.

1601 : 2008-06-27 : Jelmer Vernooij : jelmer@samba.org-20080627130858-yrwfjhsuk22m16p7

Refactor consistency checking of channel modes.

1600 : 2008-06-27 : Jelmer Vernooij : jelmer@samba.org-20080627124443-7o7r6hiwsi95mrx8

Use double hashes for real comments, a single hash for commented-out options.

1599 : 2008-06-26 : Jelmer Vernooij : jelmer@samba.org-20080626213649-ifxsuwuzc52ldfti

Also avoid warning when there are no clients around, only when there are more than one.

1598 : 2008-06-22 : Jelmer Vernooij : jelmer@samba.org-20080621231404-txmwzzw75qvwdyl6

Fix handling of 328 and 901. Thanks, tomaw.

1597 : 2008-06-21 : Jelmer Vernooij : jelmer@samba.org-20080621154519-sd3446uhm3hwkbuv

Merge trunk.

1596 : 2008-06-15 : Jelmer Vernooij : jelmer@samba.org-20080614225517-buz38g07qlpxhrrb

Start working on 3.0.8.

1595 : 2008-06-14 : Jelmer Vernooij : jelmer@samba.org-20080614192634-swptq9w3y8hmgs49

release 3.0.7.

1594 : 2008-06-13 : Jelmer Vernooij : jelmer@samba.org-20080613125446-zv90a77s2eljg11l

Fix segfault in socks code.

1593 : 2008-06-04 : Jelmer Vernooij : jelmer@samba.org-20080604163638-s9uvti324hg02h3e

Handle 328 WHOIS replies.

1592 : 2008-06-04 : Jelmer Vernooij : jelmer@samba.org-20080604160107-rjcw6l2yqjbcsk93

handle 326 WHOIS replies.

1591 : 2008-06-02 : Jelmer Vernooij : jelmer@samba.org-20080602211156-ofoee35i8fp2mqac

Avoid too much warnings about mode arguments.

1590 : 2008-06-02 : Jelmer Vernooij : jelmer@samba.org-20080602134706-onc14p15ky3x18np

Check for consuming too much arguments.

1589 : 2008-05-29 : Jelmer Vernooij : jelmer@samba.org-20080529020332-szri5yunuiy240l4

Improve description for irssi.

1588 : 2008-05-17 : Jelmer Vernooij : jelmer@samba.org-20080517175311-f84072wlq1lkt08u

Fix typo for learn-nickserv variable.

1587 : 2008-05-14 : Jelmer Vernooij : jelmer@samba.org-20080514122514-tvb6bkh5nf908pmi

Support listening on IPv6.

1586 : 2008-05-11 : Jelmer Vernooij : jelmer@samba.org-20080511191705-vgnms0swi83sqaec

Rename network.[ch] -> connection.[ch].

1585 : 2008-05-11 : Jelmer Vernooij : jelmer@samba.org-20080511153848-5xlxrn77xmufe96p

Remove unused struct member.

1584 : 2008-05-10 : Jelmer Vernooij : jelmer@samba.org-20080510014155-w1ggfqorzw7s7lge

Avoid disconnecting clients that are still waiting for a connection.

1583 : 2008-05-02 : Jelmer Vernooij : jelmer@samba.org-20080502201541-k1wwi8trjwrykva1

Fix bug in new redirect code.

1582 : 2008-05-02 : Jelmer Vernooij : jelmer@samba.org-20080502200317-5uczfba94h6u1tx3

Fix bug in mode handling.

1581 : 2008-05-02 : Jelmer Vernooij : jelmer@samba.org-20080502195941-v3m6wsomnc7zb18c

Properly warn when receiving invalid modes.

1580 : 2008-05-01 : Jelmer Vernooij : jelmer@samba.org-20080501012413-i0s7dw8p4qwpbpd1

Support MODE +J

1579 : 2008-05-01 : Jelmer Vernooij : jelmer@samba.org-20080501011515-u1jx05gfr34681ev

Support MODE +d

1578 : 2008-04-30 : Jelmer Vernooij : jelmer@samba.org-20080430182224-e7henfjxq0hyb5ga

Some doc updates.

1577 : 2008-04-30 : Jelmer Vernooij : jelmer@samba.org-20080430175227-3bn1g4wct9dqgkot

Add missing header file.

1576 : 2008-04-30 : Jelmer Vernooij : jelmer@samba.org-20080430174248-g93g0bbuthymmepx

Remove global in redirect code.

1575 : 2008-04-30 : Jelmer Vernooij : jelmer@samba.org-20080430171623-jr4a71j43nc26i3h

Import formatting fixes from Python branch.

1574 : 2008-04-30 : Jelmer Vernooij : jelmer@samba.org-20080430170837-9h4tiign273wm10a

Add convenience function for creating channel states.

1573 : 2008-04-30 : Jelmer Vernooij : jelmer@samba.org-20080430170041-ze5pp8flr41bsw1w

move functions.

1572 : 2008-04-30 : Jelmer Vernooij : jelmer@samba.org-20080430161402-p915d34xql2un120

Use callbacks for networks.

1571 : 2008-04-30 : Jelmer Vernooij : jelmer@samba.org-20080430155737-ryf6sx8j5tthfg7y

Remove network_config member from network.

1570 : 2008-04-30 : Jelmer Vernooij : jelmer@samba.org-20080430151552-0bizwxccgnkjooo1

Modes are now tracked correctly.

1569 : 2008-04-30 : Jelmer Vernooij : jelmer@samba.org-20080430140526-z1jtdblau8zs4ik3

Merge workstation branch.

1568 : 2008-04-30 : Jelmer Vernooij : jelmer@samba.org-20080430125303-w6j21vdc3guu0fd0

Add const.

1567 : 2008-04-30 : Jelmer Vernooij : jelmer@samba.org-20080430124606-nlcpnor1g4stwe7c

Fix const.

1566 : 2008-04-30 : Jelmer Vernooij : jelmer@samba.org-20080430124541-ox811pst03aeobpx

Support storing exception lists in state.

1565 : 2008-04-27 : Jelmer Vernooij : jelmer@samba.org-20080427152209-hzw5x4jl8wibxljs

Fix handling of CTCP requests in combination with report-time.

1564 : 2008-04-27 : Jelmer Vernooij : jelmer@samba.org-20080427151304-zwcat6hax2qsuokt

Add test for prefix_time function.

1563 : 2008-04-27 : Jelmer Vernooij : jelmer@samba.org-20080427143046-fvf3lumo0cnjlgvl

Add create-implicit option.

1562 : 2008-04-20 : Jelmer Vernooij : jelmer@samba.org-20080420215116-1zsh2v2v5jwkguxs

Import blocking socket fixes from libsoap, avoid blocking /dev/random in SSL code.

1561 : 2008-04-16 : Jelmer Vernooij : jelmer@samba.org-20080416093321-di6um3wy0e6lwx01

Be less verbose about unredirectable responses.

1560 : 2008-04-15 : Jelmer Vernooij : jelmer@samba.org-20080414220834-5jzc205p69nj5c2g

Handle client-specific admin commands being run without a client more gracefully.

1559 : 2008-04-14 : Jelmer Vernooij : jelmer@samba.org-20080413224527-g15yhfhk4auom177

Start working on 3.0.7.

1558 : 2008-04-14 : Jelmer Vernooij : jelmer@samba.org-20080413222931-hid1wgbwld4d03kd

Merge 3.0.6.

1557 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410172921-mglih9flx9uqart6

Send channel mode during replication.

1556 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410170738-isjxmfjquxecnnw5

add variable to send commands when logged into server.

1555 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410164317-oa0esxse1uuujtto

Support 249 response code.

1554 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410163715-thblln2ae2ryncbk

Send topic change time if known.

1553 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410160902-6k2uaqqs6zfa8mmg

Fix assertion in new transport code.

1552 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410160714-zpapy5c6j2ms4oot

Fix outgoing SSL connections.

1551 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410042104-iobaaf6fu1ot1mt9

Fix formatting in NEWS.

1550 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410042003-0h5ayetwsg348a31

Fix handling of connection refused when connecting.

1549 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410035912-nxrj7fmmdikx5u70

Use transport code in network.

1548 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410035421-eg516urf2sqcyany

Make distinction between disconnect and hangup.

1547 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410025611-f3lcr14j2t8h3kdh

Occasional repeating of lines should now no longer occur.

1546 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410025513-gbi92w2tjk38uslk

Flush early for networks as well.

1545 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410024639-jzrwpz80tvsvxxdx

reintroduce flush temporarily.

1544 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410022156-gql5bh0c0boacctb

Fix memory leak in error path.

1543 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410021827-ezjxu9zau0du6t96

Remove flush from irc_send_line.

1542 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410020025-vn3f8604jgvubt2x

Add test for sending a large number of lines using transport.

1541 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410014806-lf83guaz0rf3hpef

Fix valgirnd errors.

1540 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410004522-m8q750apwa7ti50n

Remember last time a line was sent.

1539 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410002951-5te9amkobl5w9mld

provide iochannel-less version of client_init.

1538 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410002336-qze06250urf8v39h

Start working on transport tests.

1537 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410001440-m04aejyz8cxa2j5p

Specify transport when creating client struct.

1536 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410000900-ryng7hl90p7nwv10

Allow setting callbacks for transport later.

1535 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080410000508-nw4ba6dbpu5pk7l7

Fix test failures.

1534 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080409235823-huoxwzmusujpta0m

Use callbacks structure for convenience.

1533 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080409234011-dft1gvcusrolloim

Add transport_send_args().

1532 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080409233403-nje9pe113sl6oa7d

Move error handling to transport.

1531 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080409231202-ms6xaoqky0c1om7d

Reconcile receive functions.

1530 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080409224939-mkehnn89x09556ix

Move first bit of receiving lines to transport.

1529 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080409223425-xm80vdajc3zx18tq

Move more code to transport code.

1528 : 2008-04-10 : Jelmer Vernooij : jelmer@samba.org-20080409220331-shef1gy0ptppwt1y

Move send function to transport code.

1527 : 2008-04-09 : Jelmer Vernooij : jelmer@samba.org-20080409203251-us8m720k89th2rfx

Move more functionality to transport.

1526 : 2008-04-09 : Jelmer Vernooij : jelmer@samba.org-20080409202233-r1vzcwqaa0y8frxj

Move transport code into a separate file.

1525 : 2008-04-08 : Jelmer Vernooij : jelmer@samba.org-20080408020650-5v5lvki4ewckocbf

Fix timestamp parsing (?) in topic who time.

1524 : 2008-04-08 : Jelmer Vernooij : jelmer@samba.org-20080408015148-o5z6unyab86m12t8

Fix early free regression.

1523 : 2008-04-07 : Jelmer Vernooij : jelmer@samba.org-20080407141151-d2t0ko1ffieedqgv

Fix another bug in substitution code.

1522 : 2008-04-07 : Jelmer Vernooij : jelmer@samba.org-20080407135714-j6ua21g393itab3k

Fix doc target.

1521 : 2008-04-07 : Jelmer Vernooij : jelmer@samba.org-20080407135126-zqjmhtaz799jq54q

Fix bug in log subsitution code, add tests.

1520 : 2008-04-07 : Jelmer Vernooij : jelmer@samba.org-20080407135014-jhasi0198mcepcds

Support CHANSERV command when redirecting.

1519 : 2008-04-07 : Jelmer Vernooij : jelmer@samba.org-20080407131526-nxtlkkz4hiu5n5bi

Don't install ctrlproxyd by default.

1518 : 2008-04-07 : Jelmer Vernooij : jelmer@samba.org-20080407125303-4r5m6290qmm6ynfd

Fix formatting.

1517 : 2008-04-07 : Jelmer Vernooij : jelmer@samba.org-20080407125114-72ley0ljlaa9cz2p

Avoid writing nick changes and quits to nick-specific files when not in a query with a user.

1516 : 2008-04-07 : Jelmer Vernooij : jelmer@samba.org-20080407005025-9ugxx03qfeot1r4j

Use dynamic allocation of substitution array.

1515 : 2008-04-07 : Jelmer Vernooij : jelmer@samba.org-20080407004106-s32gyalekt3080xz

Move subsitution code to a separate file.

1514 : 2008-04-07 : Jelmer Vernooij : jelmer@samba.org-20080406234821-nl1dua45paagk3in

Fix testsuite linking.

1513 : 2008-04-06 : Jelmer Vernooij : jelmer@samba.org-20080406040755-mdi42uk6ecqirx9z

Allow clients to handle CTCP requests.

1512 : 2008-04-06 : Jelmer Vernooij : jelmer@samba.org-20080406001354-t5v8bxjaa62bbd1b

reopen log files on SIGHUP.

1511 : 2008-04-06 : Jelmer Vernooij : jelmer@samba.org-20080406000441-1cx41l0ai7bher1j

Merge trunk.

1510 : 2008-04-03 : Jelmer Vernooij : jelmer@samba.org-20080403165350-d6cfff7b7tml0hdp

Also recognize bind setting in global network configuration.

1509 : 2008-04-01 : Jelmer Vernooij : jelmer@samba.org-20080401114024-4ex2dwx3pt1l6gdp

Fix tests.

1508 : 2008-04-01 : Jelmer Vernooij : jelmer@samba.org-20080331230011-9crcapz9vl0io2vi

Sanity check PREFIX early.

1507 : 2008-03-25 : Jelmer Vernooij : jelmer@samba.org-20080325162625-cynvsbqo7iebduer

Add rule for creating cscope file.

1506 : 2008-03-21 : Jelmer Vernooij : jelmer@samba.org-20080321115424-ibbufejebcekt024

Fix memory leak in admin-cmd.

1505 : 2008-03-21 : Jelmer Vernooij : jelmer@samba.org-20080321115207-ecn3ope7ak71yl2t

Fix colon in front of channel names.

1504 : 2008-03-15 : Jelmer Vernooij : jelmer@samba.org-20080315173103-gd7353j2vbzcbmvj

Move error utility function to lib/

1503 : 2008-03-15 : Jelmer Vernooij : jelmer@samba.org-20080315172933-1xxmmk6v16ql2xba

Make welcome function overridable.

1502 : 2008-03-15 : Jelmer Vernooij : jelmer@samba.org-20080315171344-d40iqhw9zl6ckhxi

Add separate callbacks struct for clients.

1501 : 2008-03-15 : Jelmer Vernooij : jelmer@samba.org-20080315165024-lmvkoy7zpayvyl0f

Allow users to specify a log function to client.

1500 : 2008-03-15 : Jelmer Vernooij : jelmer@samba.org-20080315161756-wtulm34y6p2i8bec

Make default_origin static to avoid confusing clients.

1499 : 2008-03-15 : Jelmer Vernooij : jelmer@samba.org-20080315140616-2d50aeim7wfvhq4d

Let 'make' always do the right thing (even when there is no configure script
present).

1498 : 2008-03-09 : Jelmer Vernooij : jelmer@samba.org-20080309145102-jr7fr132k8v3e045

Add motd test.

1497 : 2008-03-09 : Jelmer Vernooij : jelmer@samba.org-20080309144104-ioggcp384elwqn7n

Fix CFLAGS when using gcov.

1496 : 2008-03-09 : Jelmer Vernooij : jelmer@samba.org-20080309144046-hh3ge1x21p2zi0g7

Add tests for pidfile functions.

1495 : 2008-03-09 : Jelmer Vernooij : jelmer@samba.org-20080309143030-a3uq54y67wkg2bla

Remove more gcov output.

1494 : 2008-03-09 : Jelmer Vernooij : jelmer@samba.org-20080309140049-vrvnf4rb329machs

Fix formatting.

1493 : 2008-03-09 : Jelmer Vernooij : jelmer@samba.org-20080309124835-dbduggndx5fqtait

Use my samba.org email address.

1492 : 2008-03-09 : Jelmer Vernooij : jelmer@samba.org-20080309123225-qm20sdkg0453qri3

Add log_support_reopen() function.

1491 : 2008-02-29 : Jelmer Vernooij : jelmer@samba.org-20080229005434-loa7z8qznk3438cu

Fix order in which plugins are handled.

1490 : 2008-02-29 : Jelmer Vernooij : jelmer@samba.org-20080229005155-flc2wqe7hf782u5w

Fix handling of empty pid files.

1489 : 2008-02-29 : Jelmer Vernooij : jelmer@samba.org-20080229004754-s0n4wvwobmkya3d0

Deal with out of disk space situations.

1488 : 2008-02-29 : Jelmer Vernooij : jelmer@samba.org-20080229003648-vxnmr9hqic4ktc7d

Change meaning of FALSE return value for linestack_insert_line to mean unable to write rather than nothing written.

1487 : 2008-02-29 : Jelmer Vernooij : jelmer@samba.org-20080229003219-uj19mr0pd000r0sq

Allow linestack to be NULL.

1486 : 2025-12-27 : Jelmer Vernooij : jelmer@samba.org-20251227022222-dn4j39bj54p46acc

Use simpler coverage flags.

1485 : 2008-02-20 : Jelmer Vernooij : jelmer@samba.org-20080220143308-neta1475pprbwnyy

Fix prototype.

1484 : 2008-02-20 : Jelmer Vernooij : jelmer@samba.org-20080220143135-rqnejzb2gt34887e

use pointer to network_info everywhere.

1483 : 2008-02-20 : Jelmer Vernooij : jelmer@samba.org-20080220141855-pf6wp647jcnvjqks

Rename channel_state -> irc_channel_state.

1482 : 2008-02-20 : Jelmer Vernooij : jelmer@samba.org-20080220140427-8k5bm3avm9anpf1i

Rename network_state -> irc_network_state.

1481 : 2008-02-20 : Jelmer Vernooij : jelmer@samba.org-20080220125807-zm2exf66uudkvwx2

Fix syntax.

1480 : 2008-02-20 : Jelmer Vernooij : jelmer@samba.org-20080220123627-y8arhm2l97dy7ufo

Readd accidently removed variables.

1479 : 2008-02-20 : Jelmer Vernooij : jelmer@samba.org-20080220123149-m6lcvle4kjqd7edv

Update copyright year

1478 : 2008-02-20 : Jelmer Vernooij : jelmer@samba.org-20080220122103-3bc1au49lb21d6el

Clean up ctrlproxyd in make clean.

1477 : 2008-02-20 : Jelmer Vernooij : jelmer@samba.org-20080220105358-7g07geqn695lsfs3

Some documentation updates.

1476 : 2008-02-20 : Jelmer Vernooij : jelmer@samba.org-20080220105249-fddf3os7f1xbvvsb

Some docstrings.

1475 : 2008-02-19 : Jelmer Vernooij : jelmer@samba.org-20080219225921-jg24pqiwc1mbd47s

Simplify buffer handling.

1474 : 2008-02-19 : Jelmer Vernooij : jelmer@samba.org-20080219215425-3141wzu7nnk975m1

Support NICKSERV command when tracking messages.

1473 : 2008-02-12 : Jelmer Vernooij : jelmer@samba.org-20080212160322-c6j4u6rr6usojkzp

Allow calling function in listener when a new client attaches.

1472 : 2008-02-12 : Jelmer Vernooij : jelmer@samba.org-20080212151026-2jm8qs19i5vj4ia9

Couple of misc fixes for ctrlproxyd.

1471 : 2008-02-12 : Jelmer Vernooij : jelmer@samba.org-20080212145327-2rfjj73mul9s9rxs

Support inetd-style in ctrlproxyd.

1470 : 2008-02-12 : Jelmer Vernooij : jelmer@samba.org-20080212142620-0mocno0s6klqa2t7

Fix the build.

1469 : 2008-02-12 : Jelmer Vernooij : jelmer@samba.org-20080212142138-b4uh13bmngqgs96k

Add separate struct for ops.

1468 : 2008-02-12 : Jelmer Vernooij : jelmer@samba.org-20080212140610-de2k37zjbdxw5xyc

Make network connect bit in listenre configurable.

1467 : 2008-02-12 : Jelmer Vernooij : jelmer@samba.org-20080212134651-w4nvw50f9qvovg3j

Allow customizing socks username/password handling in listeners.

1466 : 2008-02-12 : Jelmer Vernooij : jelmer@samba.org-20080212133653-bcmxt0vbkp55iiia

Fix formatting.

1465 : 2008-02-12 : Jelmer Vernooij : jelmer@samba.org-20080212133527-0ztwvmonzcfj781v

Change callback signatures.

1464 : 2008-02-12 : Jelmer Vernooij : jelmer@samba.org-20080212021749-32xy7t15emsx71c8

Use syslog for logging in ctrlproxyd.

1463 : 2008-02-11 : Jelmer Vernooij : jelmer@samba.org-20080211024203-pi7wt95ylx33ldm4

Rename start_listener -> listener_start, stop_listener -> listener_stop for consistency.

1462 : 2008-02-09 : Jelmer Vernooij : jelmer@samba.org-20080209191609-u4711k5klz22bm9u

Fix crash if nick that set banlist entry can't be found.

1461 : 2008-02-06 : Jelmer Vernooij : jelmer@samba.org-20080206205343-f492wwa0n80wfwn5

consistent function signatures.

1460 : 2008-02-06 : Jelmer Vernooij : jelmer@samba.org-20080206202127-51cfrjp5gw22wu5d

Add -F option.

1459 : 2008-02-06 : Jelmer Vernooij : jelmer@samba.org-20080206193734-hvse8k2y01jaor5u

More work making the client code more generic.

1458 : 2008-02-06 : Jelmer Vernooij : jelmer@samba.org-20080206192547-sud7wdceh9kkog3p

Simplify some more code.